Node object without revision causes fatal error

Open on Drupal.org →

Created on 20 November 2024, 5 months ago

Problem/Motivation

The block visibility condition assumes there will be an existing revision if the node object is not empty when the condition is checked. This is not guaranteed to be true. If the node object is not empty and there's no revision, it causes a fatal error. This is happening on Panopoly and a child distribution; there may be other cases where the node object is not empty but there is not an existing revision.

Steps to reproduce

Create a Panopoly 3.0.x site using its composer template: composer create-project panopoly/panopoly-composer-template:10.x-dev panopoly3 --no-interaction
Install the default profile: drush -y si panopoly
Add the block_condition_published module via Composer and enable it.
In the Block Layout admin page, add a block to a region and configure it to display only if the node is unpublished. For example, add the Who's Online block to the Highlighted region and check the boxes for Published and Negate the condition.
Save the block config and the layout.
Visit a published node provided by the Panopoly install.
Note the block does not appear. This is the expected behavior.
Edit the node. Uncheck the Published box and save.
Note the block appears. This is the expected behavior.
Visit the Add Content page for a content type, for example /node/add/panopoly_content_page.
Note the error: "Call to a member function get() on null in Drupal\block_condition_published\Plugin\Condition\NodePublishedState->evaluate() (line 136 of modules/contrib/block_condition_published/src/Plugin/Condition/NodePublishedState.php)."

Proposed resolution

Check to make sure the revision ID exists before trying to get the published status.

Remaining tasks

MR and test.

User interface changes

None.

API changes

None.

Data model changes

None.

🐛 Bug report

Status

Active

Version

1.0

Component

Code

Created by

🇺🇸United States cboyden

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!2Node object without revision causes fatal error
Open
🇺🇸United States cboyden
updated 5 months ago

Comments & Activities

Issue created by @cboyden
Merge request !2Issue #3488761: Add check for revision → (Open) created by cboyden
Comment 5 months ago →
🇺🇸United States cboyden
The MR adds a simple check for a non-empty vid from the latest revision. If it's empty, the condition is treated the same as if the node object was empty.
Comment 5 months ago →
🇦🇹Austria Grienauer Vienna
Thank you for the MR! we will check it out.
Comment 5 months ago →
🇦🇹Austria granik Vienna
@cboyden thanks for your catch!
The problem can be, that if you skip the validation in your case, the module will not check if node is published or not. I guess there should be a check like $node->isPublished(), instead just returning TRUE.

p.s. this check has been added just because of drupal moderation states(more info here), so in case if the regular published/unpublished status is used, there is no need to check the revision state. The code just checks all possible user cases.

I'll try to work on this issue as soon as possible.

Comment 4 months ago →

granik → committed 1f57a810 on 1.0.x

Issue #3488761 by cboyden: Node object without revision causes fatal...

Comment 4 months ago →
🇦🇹Austria granik Vienna
Committed to 1.0.x branch.
Comment 3 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024