Redirect correctly after first time plugin setup

Ah - wrong patch! Correct one here.

Is this possibly a duplicate of 🐛 Full Setup not working on 8.x-1.7 Active or are they separate faults?

Drupal.org (and the TFA project) have migrated away from patch files. The infrastructure to test and merge has been replaced with Merge Requests.

More details on working with merge requests may be found in Using GitLab to Contribute to Drupal → .

Setting needs-work to allow for feedback on if issues are related, and to convert to MR.

This is a different issue here, and at somepoint I'll make a MR for this change.

Might also be related to 🐛 One setup step remaining, two QR Code Scans required Active

Picking it up, creating MR.

Created the MR !100.
Please anyone check for failing PHPUnit tests, as I have no knowledge of it.

Needs work as the proposed patch implies there is a deeper root fault that should be identified and fixed.

Again tried to reproduce the error in Drupal 10.4.0, there seems to be no issue for 2.x branch of the modulew. On first time Tfa setup with TOTP, in Tfa configuration page if the "Redirect users on login to TFA Setup Page" option is enabled, the user is correctly redirected to the tfa overview form asking the user to set up tfa.

@sayan_k_dutta 'Redirect users on login to TFA Setup Page' impacts the Login logic this issue apepars to be about the Token Provisioning (TFASetupForm) which is indepdnet of the login logic.

setRedirect() is overridden if the form is 're-building'. We do trigger from rebuild in multiple places. This is the most likely cause and should be investigated with a debugger to validate.