Contrib.social

Full Setup not working on 8.x-1.7

Open on Drupal.org →
Created on 31 May 2024, 10 months ago

Problem/Motivation

I upgraded the module from 8.x-1.3 to 8.x-1.7 and noticed that the full setup was not working anymore.

Steps to reproduce

1. Enable TFA
2. Enable 2 plugins, i had recovery codes and totp.
3. Setup the recovery codes, you will see the recovery codes twice, and will be redirected back to the overview.

Proposed resolution

In the TfaSetupForm, first the code checkes the given method if its valid, later in the code the method can be swicthed by the "step_method" value in the storage, but the "$setup_plugin_id" is not - which will be given to the TfaSetup class to build the form. As this is the plugin is not changed, the setup build the method in the url twice.

🐛 Bug report
Status

Active

Version

1.7

Component

Code

Created by

marcellinostroosnijder

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @marcellinostroosnijder
  • Comment 10 months ago →
    marcellinostroosnijder

    I added a patch that creates the plugin, after the "next_method" check has been done

  • Status changed to Needs review 10 months ago
  • Comment 10 months ago →
    marcellinostroosnijder
  • Status changed to Needs work 10 months ago
  • Comment 10 months ago →
    🇺🇸United States cmlara

    Thank you for the patch.

    The patch file workflow has been deprecated on D.O. due to the upcoming decommissioning of DrupalCi on July 1st when DrupalCi will be fully replaced by GitLabCi.

    Patch files can only be tested in DrupalCi while MR’s can be tested in both DrupalCi and GitLabCi. This means after July 1st only MR’s will be testable on Drupal.org.

    Many modules, including TFA, have already adopted GitLab CI in order to be prepared for decommissioning. Part of the adoption processes involves disabling DrupalCi to conserve resources.

    Due to above reasons the TFA project can only work with MR’s and will need the patch file converted to a MR to continue.

  • First commit to issue fork.
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024