Move the PostgreSQL override of the entityQuery to the pgsql module

Ready for a review.

Only comment is if we can add a simple deprecation test for the class

The requested deprecation test has been added.
Back to NR.

@smustgrave: Thank you for the review.

Thanks! rest of the changes LGTM.

This patch does not implement the deprecation for 11.x correctly... before:

> \Drupal::service('pgsql.entity.query.sql')
= Drupal\Core\Entity\Query\Sql\pgsql\QueryFactory {#7704}

after

> \Drupal::service('pgsql.entity.query.sql')

   Error  Class "Drupal\pgsql\EntityQuery\QueryFactory" not found.

The core classes cannot extend the pgsql classes. We should just deprecate the code and not extend from the new code.

As requested by @alexpott, the extending of the deprecated classes to the new ones in the pgsql module have been removed and the original code has been restored..

Appears to be 1 open thread on MR.

I have added the by @alexpott requested deprecation to the service in core.services.yml.

Moving the deprecation to the constructor (like we do for plugins) resolves the issues caused by compiler passes reflecting on the class. This is very similar to what we do for plugins. They can't have deprecations in the main body of a class for a similar reason.

@alexpott: Moving the deprecation to the constructor was the solution. Thank you for your help. It is clear to me why you are a core framework manager and I am not. ;-)

All code changes look good to me.
All deprecations have testing.
We have a change record.
For me it is RTBC.

Seems good to me. Do we need to trigger a "PHP 8.3 PostgreSQL 16" test run?

Do we need to trigger a "PHP 8.3 PostgreSQL 16" test run?

I have tried, but I am not allowed to do that.