- Issue created by @Liam Morland
- 🇮🇳India kulpratap2002
Replaced \Drupal calls with dependency injection and solve phpcs issue also, Please review.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
This issue is only about using dependency injection and should not include any other changes.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Does this really need to use
::backwardsCompatibleCall()
? Within days, Drupal 10.3 will be the oldest supported. - 🇮🇳India kulpratap2002
It was resolved in this issue: https://www.drupal.org/project/url_embed/issues/3488448 📌 Remove use of DeprecationHelper::backwardsCompatibleCall() Active
Now i also resolve in this issue.
Thanks. - 🇮🇳India kulpratap2002
@liam_morland, I have now removed the use of DeprecationHelper::backwardsCompatibleCall().
Please review,
Thank you - 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Thanks for the patch.
I suggest using constructor property promotion.
- Status changed to Needs review
24 days ago 12:33pm 30 January 2025 - 🇮🇳India kulpratap2002
@liam morland I have applied the dependency injection through constructor property promotion, but for file "UrlEmbedFilter.php" when I am adding constructor property promotion it fails the PHPUnit pipeline that's why I have reverted the changes in it.
Now Please review.
Thanks - 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Did you add a visibility declaration (like
protected
) to all the properties? It should be added only to those properties that are defined in this class. Any inherited properties should not get a visibility declaration.