Upgrade twig/twig to 3.15.0

    1) /builds/issue/drupal-3488365/vendor/symfony/deprecation-contracts/function.php:25
    Since twig/twig 3.15: Instantiating "Twig\Node\Node" directly is deprecated; the class will become abstract in 4.0.

Added the most breaking changes to summary

- https://github.com/twigphp/Twig/pull/4335
- https://github.com/twigphp/Twig/pull/4398

@andypost given we are so close to 11.1/10.4 it might be worth just skipping the new deprecations and then fixing them individually in followups like we did for the last round in Twig?

@longwave sounds like the best option!

Filed plan issue 🌱 Fix twig 3.15 deprecations Active

PS: looks like few tests still needs tuning

On other hand there's only 3 places to fix in core and tests are green https://git.drupalcode.org/project/drupal/-/merge_requests/10247

As new classes in-use - pinned the minimal version

Fixed deprecations as they are regular expressions, thanks @longwave

Looks good to me, I think we should just commit the fixes here given it is only changing Node to Nodes - not worth deferring that to a followup.

Ideally we will get this into both 11.1.0 and 10.4.0.

I agree, we should commit the fixes too if possible. Don't want the same as we did with 3.14.

The code looks good. The split between node and nodes did confuse me a little when seeing the namespace still there, but that does make sense.

Id opt to fix with deprecation fixes. Since, as longwace argues, its pretty small change.

+1 on rtbc

Committed and pushed to 11.x, 11.1.x, 10.5.x and 10.4.x. Thanks!

longwave → closed merge request !10252

longwave → closed merge request !10247

This broke various tests on 10.4/10.5:

      2x: Since twig/twig 3.15: Using the "deprecated", "deprecating_package",
    and "alternative" options is deprecated, pass a "deprecation_info" one
    instead.

Fail in tests seems like a random BlockCacheTest fail. RTBC-ing

Committed and pushed to 10.5.x and 10.4.x, thanks!

longwave → closed merge request !10359

There's 3.16 release but looks to downgrades detected https://github.com/twigphp/Twig/blob/v3.16.0/CHANGELOG

Added it for 10.4/10.5 in 📌 Update Composer dependencies for 10.4.0-RC1 Active

Automatically closed - issue fixed for 2 weeks with no activity.