SearchApiDate views field plugin should document it's for timestamps

Created on 18 November 2024, 5 months ago

Problem/Motivation

The docs for Drupal\search_api\Plugin\views\field\SearchApiDate say:

> * Handles the display of date fields in Search API Views.

But this isn't true. Date fields -- that is, fields of type 'datetime' provided by core -- don't use this field handler, they get the default one, SearchApiStandard.

AFAICT SearchApiDate is only for timestamp fields such as the 'created' field on entities.

Steps to reproduce

Proposed resolution

Remaining tasks

๐Ÿ› Bug report
Status

Active

Version

1.0

Component

Documentation

Created by

๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom joachim

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @joachim
  • First commit to issue fork.
  • Merge request !191Correct Documents. โ†’ (Open) created by chandansha
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia chandansha

    I tryed to fixed documents.Please review and let me if i am wrong to fixed it.
    Thanks!!

  • Pipeline finished with Success
    5 months ago
    Total: 429s
    #343069
  • ๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom joachim

    LGTM, though maintainer will confirm this is correct.

  • ๐Ÿ‡ฆ๐Ÿ‡นAustria drunken monkey Vienna, Austria

    Thanks for the suggestion!
    However, the plugin looks like it could just as easily be used for any other date fields, so I donโ€™t think this change is really necessary. In particular, fields with type datetime_iso8601 should be using this plugin as well. If you think others should as well, then maybe we should rather change that than adapt the doc comment.

Production build 0.71.5 2024