- Issue created by @amateescu
- π¬π§United Kingdom longwave UK
One question, otherwise this looks great; the gold standard of hook conversions :D
- πΊπΈUnited States nicxvan
Not sure if I agree with marking hook classes as final.
Until we have a proper way to handle replacement long term I think it's better to leave them not final.
- π·π΄Romania amateescu
π [policy, no patch] Hook classes should not be marked final Active seems contentious, so in order to move forward with this cleanup I got rid of
final
. - πΊπΈUnited States nicxvan
This is so nice, it's a significant reduction in lines too while making it so much cleaner.
If the community decides on final we can easily add that back in.
The only other note is hook help could be updated to return a string always, I would not bother for this issue that will be handled here: π Add string return type to all hook_help implementations Active .
- πΊπΈUnited States nicxvan
Actually I'm working on the hook_help now and it will conflict here, so I'll exclude that but I'm going to make a suggestion for the fix so it's consistent and exclude workspaces from the branch I'm working on.
Give me a few minutes to make a suggestion.
- πΊπΈUnited States nicxvan
Feel free to ping me once you take a look and I can review this again.