Cleanup hook implementations in the Workspaces module

This should do it :)

One question, otherwise this looks great; the gold standard of hook conversions :D

Fixed :)

Not sure if I agree with marking hook classes as final.

Until we have a proper way to handle replacement long term I think it's better to leave them not final.

📌 [policy, no patch] Hook classes should not be marked final Active seems contentious, so in order to move forward with this cleanup I got rid of final.

This is so nice, it's a significant reduction in lines too while making it so much cleaner.

If the community decides on final we can easily add that back in.

The only other note is hook help could be updated to return a string always, I would not bother for this issue that will be handled here: 📌 Add string return type to all hook_help implementations Active .

Actually I'm working on the hook_help now and it will conflict here, so I'll exclude that but I'm going to make a suggestion for the fix so it's consistent and exclude workspaces from the branch I'm working on.

Give me a few minutes to make a suggestion.

Feel free to ping me once you take a look and I can review this again.

That suggestion seems fine, applied it to the MR :)

Since you went through updating this module I'd love your insights here 📌 [meta] Clean up hook classes in core Active any thoughts on ways to group them etc or other thoughts or observations would be great.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Needs reroll with an updated baseline following 📌 Bump PHPStan to version 2.0.0 Active

Rerolled.

catch → closed merge request !10223

OK let's tackle those in another issue especially since they're subtly different after all.

Committed/pushed to 11.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.