- Issue created by @pameeela
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
📌 Add announcements block to the welcome dashboard Active is RTBC
- 🇺🇸United States phenaproxima Massachusetts
Can...can we just do this as part of 📌 Add announcements block to the welcome dashboard Active and close this as a duplicate?
- First commit to issue fork.
- Merge request !241Remove announcements link from the admin menu → (Merged) created by Unnamed author
- 🇳🇮Nicaragua dinarcon
Second attempt at contributing to Drupal CMS... :-)
I was not expecting to use a config action for this. Some of the thought process I went through...
- The menu link is content not configuration.
- This link is provided by the Announcements module. The menu UI does not allow to change it. But it can be disabled.
- Let's implement
hook_menu_links_discovered_alter
. But where? - Unless I am missing something, there is no custom modules in Drupal CMS.
drupal_cms_installer
seems like a place where hooks are implemented. After looking at the code,drupal_cms_installer_uninstall_myself
uninstalls the installer. :)- By disabling the menu link via the UI, I noticed there is a
core.menu.static_menu_link_overrides.yml
configuration file is created. - Tried to place the configuration file in
recipes/drupal_cms_dashboard/config/core.menu.static_menu_link_overrides.yml
, but that did not work. - Mostly by chance, I stumbled upon an example overriding a menu link in
web/core/recipes/feedback_contact_form/recipe.yml
- Added a
simpleConfigUpdate
torecipes/drupal_cms_dashboard/recipe.yml
- Is... this... the right approach?
Developing for Drupal CMS is indeed different than doing it for Core. Looking forward to learn more and for more opportunities to contribute.
- 🇳🇮Nicaragua dinarcon
Forgot to change to NR.
Just noticed this is filed under the
Base Recipe
component. I made my change indrupal_cms_dashboard
recipe which I guess would map to theTrack: Dasboard
component. I might be overthinking things, but wanted to make sure I applied the code change in the right place. - 🇺🇸United States phenaproxima Massachusetts
Looks fine to me, but...
The drupal_cms_dashboard recipe is on the cusp of being removed (see 📌 Merge drupal_cms_dashboard into the starter recipe Active ), so this needs to go into a different recipe. Probably drupal_cms_starter is a reasonable place for it.
Other than that, this is okay by me if tests pass (you'll probably need to rerun the failed jobs at least once; we are plagued by random failures) and @pameeela approves it.
- First commit to issue fork.
- 🇳🇮Nicaragua baltowen
Moved config action to drupal_cms_starter recipe. Rebased after 📌 Merge drupal_cms_dashboard into the starter recipe Active was merged. Tests are passing. Please review.
I noticed the following in
CODEOWNERS
file:[dashboard track] @penyaskito @mtift @plopesc /recipes/drupal_cms_dashboard/
Now that the recipe has been removed, should those lines be removed from
CODEOWNERS
too? - 🇦🇺Australia pameeela
WOW thank you for doing this :) I was not sure we would be able to disable a menu link with config actions but I am so glad we can!
-
phenaproxima →
committed 4aeaf87f on 0.x authored by
dinarcon →
Issue #3488088 by dinarcon, baltowen: Remove Announcements from the...
-
phenaproxima →
committed 4aeaf87f on 0.x authored by
dinarcon →
- 🇺🇸United States phenaproxima Massachusetts
Code looks good and it's Pam-approved. That's fine enough for me! Merged into 0.x.
Automatically closed - issue fixed for 2 weeks with no activity.