Suggest Event add-ons

Created on 15 November 2024, about 1 month ago

Problem/Motivation

A number of add-ons for events are available in the contrib space. The Event recipe's composer file should suggest these, in the hopes that later on the Project Browser UX can provide an interactive way to select and add them to a site.

Proposed resolution

Update the composer file to include the suggestions.

πŸ“Œ Task
Status

Active

Component

Track: Event

Created by

πŸ‡¨πŸ‡¦Canada mandclu

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @mandclu
  • Pipeline finished with Canceled
    about 1 month ago
    Total: 165s
    #339609
  • Merge request !200Event suggests β†’ (Open) created by mandclu
  • πŸ‡¨πŸ‡¦Canada mandclu

    Here's a small MR to add suggestions for the event add-ons that already exist in the contrib space, instead of reproducing them as small, additional recipes within Drupal CMS.

  • Pipeline finished with Failed
    about 1 month ago
    Total: 610s
    #339617
  • Pipeline finished with Failed
    about 1 month ago
    Total: 608s
    #339618
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    One small nit from me, no objection otherwise.

    However, the bigger question here lands squarely in @pameeela's bailiwick. If we do decide to ship these add-ons with Drupal CMS, then we'll want to add test coverage to prove that they all apply cleanly on top of both the Events recipe and the Starter recipe.

  • πŸ‡¨πŸ‡¦Canada mandclu

    IMHO if the recipes won't be applied as part of the initial site install, it makes more sense to not load dependencies until the recipes are going to be applied. Happy to defer to @pameeela on this, however.

  • Pipeline finished with Failed
    about 1 month ago
    Total: 650s
    #339933
  • Pipeline finished with Failed
    about 1 month ago
    Total: 746s
    #339932
  • πŸ‡¦πŸ‡ΊAustralia pameeela

    Hmm. I'm not sure this is sufficient because we will be showing the event recipe in the onboarding, but are unlikely to include the idea of 'optional additions' at that point, because we want to keep the decisions to a minimum and get folks into their sites. So I definitely think there is value in having them presented in the recipes UI. (This UI is currently being scoped out and we do hope to have it for v1!)

    If someone doesn't apply the event recipe in the onboarding, then we could use the suggestions to show optional add-ons during the later application.

  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    Okay, there are two options here:

    1. Keep the three recipes in contrib, and bring them into the project template as dependencies.
    2. Merge them wholesale into Drupal CMS, and deprecate the contrib projects.

    Either way, we can show them in Project Browser. I like door #2. @tim.plunkett is agnostic. It sounds like Pam is more on the door #2 side.

    I think @mandclu must choose.

  • πŸ‡¨πŸ‡¦Canada mandclu

    I'm good with the second option.

  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    Okay, great. So the next steps here:

    • Add these recipes as dependencies to project_template/composer.json
    • Add a little test coverage to the starter recipe which confirms that they all apply on top of it

    Now that the decision has been made, this can land during beta.

  • Pipeline finished with Failed
    about 1 month ago
    Total: 71s
    #345274
  • Merge request !216Events add-ons β†’ (Open) created by mandclu
  • Pipeline finished with Failed
    about 1 month ago
    Total: 62s
    #345281
  • Pipeline finished with Failed
    about 1 month ago
    #345282
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts
  • Pipeline finished with Failed
    29 days ago
    Total: 401s
    #347182
  • Pipeline finished with Canceled
    29 days ago
    Total: 188s
    #347193
  • Pipeline finished with Failed
    29 days ago
    Total: 459s
    #347197
  • Pipeline finished with Failed
    29 days ago
    Total: 1241s
    #347205
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    Welp, this is blocked.

    The problem is that those three add-ons rely on the contributed Events recipe, which conflicts with the Drupal CMS Events recipe (although only slightly).

    I proposed one possible solution to @mandclu, which is to use strict: false (or really, selective strictness) in the contributed Events recipe. That would allow that recipe to apply harmlessly to a fully installed Drupal CMS site; indeed, I tested that locally and it got me past the conflict.

    The problem is that strict is only available in Drupal 10.4+ and 11.1+, so it would necessitate some release management tomfoolery on the contrib side.

    So this is blocked until a new version of the contrib Events recipe, which can be applied to Drupal CMS, exists.

  • Pipeline finished with Canceled
    26 days ago
    #349671
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    @mandclu fixed a couple of bugs in the upstream Events recipe, so this is now unblocked! Let's see if we can get it merged today.

  • Pipeline finished with Failed
    26 days ago
    Total: 1539s
    #349675
  • Pipeline finished with Failed
    26 days ago
    #349716
  • Pipeline finished with Failed
    26 days ago
    Total: 35s
    #349728
  • Pipeline finished with Failed
    26 days ago
    Total: 934s
    #349730
Production build 0.71.5 2024