Operation links are overly-eager render cached

Open on Drupal.org →

Created on 14 November 2024, 5 months ago

Problem/Motivation

If you look at the operation URLs at /admin/content, you'll see that URLs are whatever was cached when the operation links were first rendered. If you switch to another group, then the edit url, etc still has the previous values.

Steps to reproduce

Create 2 sites and their site prefixes of /site-1 and /site-2, respectively
Flush cache
Visit the /site-1/admin/content page
All operation URLs are generated with /site-1 prefix.
Switch to the /site-2/admin/content page
The Edit URLs still have the /site-1 prefix.

Proposed resolution

Take a page from workspaces and add a render cache required_cache_contexts for 'url.path'.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Active

Version

1.0

Component

Code

Created by

heddn Nicaragua

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!16Operation links are overly-eager render cached
Merged
heddn
updated 5 months ago

Comments & Activities

Issue created by @heddn
Comment 5 months ago →
heddn Nicaragua
Merge request !16Resolve #3487607 "Poisoned render cache" → (Merged) created by heddn
Comment 5 months ago →
heddn Nicaragua
I agree a test would be nice. If we add one, I think we could enable the views module and visit the admin/content page, as described in the IS.
Pipeline finished with Skipped
5 months ago
#344788

Comment 5 months ago →

heddn → committed a01fd26d on 1.0.x

Issue #3487607 by heddn: Operation links are render cached poisoned

Comment 5 months ago →
🇵🇪Peru marvil07
heddn → credited marvil07 → .
Comment 5 months ago →
heddn Nicaragua
Added 📌 Tests: Operation links are render cached poisoned Active for the additional tests.
Comment 4 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024