[2.0.0-beta5] Check hook_field_formatter_third_party_settings_form compatibility

pdureau → credited rajab natshah → .

Moved to RC1

Both mentionned modules seems to work as intended.

The only thing I noted is that when using a field formatter to render the field inside component the slot, the "Remove field markup" option is not there but that don't seems like a bug to me.

Thanks Olivier.

when using a field formatter to render the field inside a component's slot, the "Remove field markup" option is not there but that don't seems like a bug to me.

So, when using a field formatter to render the field inside a component's slot, field_formatter_range works but no nomarkup? If yes, we can close the issue.

So, when using a field formatter to render the field inside a component's slot, field_formatter_range doesn't work? If yes, we have to investigate

I confirm that when displaying a formatter inside a component slot, neither of field_formatter_range or nomarkup is working.

So, we don't trigger hook_field_formatter_third_party_settings_form in our Field Formatter Source plugin for slots. We need to trigger it.

Careful, there is maybe another hook to check at render time (field_formatter_range_preprocess_field?).

Olivier's job is done here. Who is taking the subject?

i updated the code, would you test again?

It works when I'm at the first level, when my formatter is the consumer plugin:

  field_tags:
    type: ui_patterns_component_per_item
    label: above
    settings:
      ui_patterns:
        component_id: 'ui_suite_dsfr:button'
        slots:
          label:
            sources:
              -
                source:
                  type: entity_reference_label
                  third_party_settings:
                    field_formatter_range:
                      order: '0'
                      limit: '0'
                      offset: '0'
                  settings:
                    link: 0
                source_id: 'field_formatter:node:article:field_tags'
    third_party_settings:
      field_formatter_range:
        order: 0
        limit: 3
        offset: 1

✅ I see only the 2nd, the 3rd and the 4th items.

But it doesn't work at deeper levels when the formatter is itself a slot source plugin.

A follow up issue will be created for the remaining fix.

Automatically closed - issue fixed for 2 weeks with no activity.