- Issue created by @smulvih2
- 🇨🇦Canada joseph.olstad
ya, but of a mess to fix there, was looking at the MR, might have been rebased so it could be really hammered.
- 🇨🇦Canada smulvih2 Canada 🍁
Ya might have been rebased from D10 to D11, PR is against 11.x now. Will look at this today and spin up a patch to fix. Luckily I have an image with the previous working code so should be easy enough to extract.
- 🇨🇦Canada smulvih2 Canada 🍁
Originally caught this issue from my feat-topic branch PR in GitHub. When I pushed it up and it ran the PR GitHub action, it failed to apply this patch. So I created a new PR for this issue to test it against the GitHub action, but now it's failing for another reason:
Fatal error: Cannot make static method Drupal\Tests\ckeditor5\Kernel\SmartDefaultSettingsTest::provider() non static in class Drupal\Tests\linkit\Kernel\CKEditor4To5Upgrade\UpgradePathTest in /var/www/html/modules/contrib/linkit/tests/src/Kernel/CKEditor4To5Upgrade/UpgradePathTest.php on line 120
make: *** [docker/Makefile:137: phpunit] Error 255Looking into this issue next.
GitHub PR - https://github.com/drupalwxt/wxt/pull/312
- 🇨🇦Canada smulvih2 Canada 🍁
Setting this to needs review, although it does fix our builds.
- 🇨🇦Canada joseph.olstad
needing this now myself, using the composer workaround for now.