Adding or editing a Page brings user into Experience Builder not entity form

Found a flaw. The route experience_builder.experience_builder requires a saved entity. There isn't a "new entity" route yet. I don't know if this issue should be modifying \Drupal\experience_builder\Controller\ExperienceBuilderController::__invoke to allow $entity to be nullable.

'base' => \sprintf('xb/%s/%s', $entity->getEntityTypeId(), $entity->id()),

This would break if null. But the entity type is a route parameter, so it could be added as a method argument.

Then in the method, if the entity is null we could pass an ID of `0`?

+1'd your first proposal, as did @lauriii, so I think you're unblocked 😄

Ready for some full reviews!

wim leers → credited f.mazeikis → .

Looking good!

Asked for a bunch of clarifications, and I think I see a whole range of small simplifications. 😇

Needs review. I think we can update some @todo to point to 📌 Consider removing baseQuery in favour of explicity requiring the params in each api call Active .

🏓 @mglaman, see #3489302-39: Preview entire page not just content area → WRT the blocker.

empty-canvas.cy.js has been failing since https://git.drupalcode.org/issue/experience_builder-3487075/-/pipelines/.... I suspect it's related to the big E2E test refactor in 📌 Adapt E2E tests to work with auto-save Active . So I just reverted that file to origin/0.x's and re-wrapped it in the .forEach that @mglaman did. And … I arrived at the exact same set of changes, not even a single character difference.

Others have touched the E2E tests more often than I have and are better equipped (and have more time) to debug this.

See review on the MR https://git.drupalcode.org/project/experience_builder/-/merge_requests/4... for the other bits of feedback.

Replied about the enhancer. And the test passed once I added video recording to debug... so let's see if it passes again when I remove videos.

Pushed the one clean-up commit I apparently failed to push on Dec 3 🙈

There's only 2 hunks that I cannot approve in principle:

1. one in the E2E test infra, but it's a trivial change: https://git.drupalcode.org/project/experience_builder/-/merge_requests/4... — and confirmed by others in another MR
2. a fairly trivial update to ui/tests/e2e/empty-canvas.cy.js, which was also worked on by @hooroomoo, who's done their fair share of writing/expanding E2E tests

So, bypassing approval for those 2 small hunks only.

wim leers → closed merge request !443

Automatically closed - issue fixed for 2 weeks with no activity.