- Issue created by @tedbow
- First commit to issue fork.
- πΊπΈUnited States tedbow Ithaca, NY, USA
I talked with @jessebaker about this. I made a test module,
xb_e2e_support
, that allows the e2e to clear the auto-save for an entity by hitting route likexb-test/clear-auto-save/node/1
I also removed the work around in
XBTestSetup
that disables auto-saving and instead enabledxb_e2e_support
This will should break the e2e test until they use the new route to clear auto-save where needed.
I am not sure how @jessebaker plans to update the tests but I think we need test coverage that proves
- When a user 1 is working at
xb/node/1
and they reload the page the components they placed should remain - When user 2 signs in to a different computer and goes to
xb/node/1
they will see the components user 1 placed. I assume there is some way to simulate the "different computer" in e2e such clearing out all brower state.
Right now there is no safeguards around locking XB when 1 user is currently working so use 2 should be continue working where user 1 left off
- When a user 1 is working at
- πΊπΈUnited States tedbow Ithaca, NY, USA
Looks good to me. I wrote the back end changes and confirmed we no longer have any todo's to this issue. I also confirmed that
experience_builder.disable_auto-save
which was the key for the state flag we used to disable auto-save is no longer in the code baseI am not that familiar with the e2e tests but I took a quick look and it seems to make sense that
loadURLandWaitForXBLoaded
has new optionclearAutoSave = true
so all the existing tests will act the same.autosave.cy.js
is the only test that usesclearAutoSave: false
. The newclearAutoSave()
functions make server side call I would expect to the test module.Will need others to approve the /ui changes
-
jessebaker β
committed a8d4ac12 on 0.x
Issue #3481736 by jessebaker, tedbow, balintbrews: Adapt E2E tests to...
-
jessebaker β
committed a8d4ac12 on 0.x
Automatically closed - issue fixed for 2 weeks with no activity.