- Issue created by @just_like_good_vibes
- First commit to issue fork.
Should we add the alts in the preview YML file, or create a props property to insert the alts?
- 🇫🇷France just_like_good_vibes PARIS
good question, we can discuss that tomorrow morning on the weekly. my short answer would be yes :
- one prop for the new customizable alt
- one prop for the new customizable title - 🇫🇷France just_like_good_vibes PARIS
nobody is assigned yet.. yassrzg, you want to try ?
- 🇫🇷France spryah
Hello,
The MR doesn't exist but it peeked at the changes and it seems to me that the line 5 should be changed
From this:
{% if caption or transcription %} {% set attributes = attributes.setAttribute('role', 'group') %} {% endif %}
To this:
{% if caption %} {% set attributes = attributes.setAttribute('role', 'group') %} {% endif %}
- Status changed to Needs review
about 2 months ago 4:18pm 4 February 2025 - 🇫🇷France just_like_good_vibes PARIS
Hello,
i found also a bug.
caption is a slot right now, and it is also used in an aria-label value.. - 🇫🇷France just_like_good_vibes PARIS
hello,
so we removed transcription, because it is outside the component and it exists as a separate component, to be placed next to the content_media.we moved caption from slot to prop.
that's all folks
-
just_like_good_vibes →
committed 7c30a037 on 1.1.x
Issue #3486992 by just_like_good_vibes, yassrzg, pdureau, spryah: ⚠️...
-
just_like_good_vibes →
committed 7c30a037 on 1.1.x
Automatically closed - issue fixed for 2 weeks with no activity.