Drupal Commerce: Entity extra field on product collides with entity extra field on product_variation

Okay finally found it. The issue is, that currently the config is missing the entity type entirely! Just the bundle is added!

So if two entities have the same bundle name, they will conflict!

Example:
entity_extra_field.extra_field.entity_extra_field.glas_plate.boilerplate_body.yml

The bundle glas_plate exists both in commerce_product and commerce_product_variation entities!

The correct configuration name would be:
entity_extra_field.extra_field.entity_extra_field.commerce_product.glas_plate.boilerplate_body.yml
entity_extra_field.extra_field.entity_extra_field.commerce_product_variation.glas_plate.boilerplate_body.yml

So the bundle gets prefixed by the entity type!

Setting priority to major as this is a risky bug.

Please check, if this is the correct approach. For non-bundleable entity types this will (correctly) use the entity type id twice.

@anybody, this change appears to be a duplication of https://www.drupal.org/project/entity_extra_field/issues/3440365 🐛 Unable to edit existing extra field or render any public site pages Active . Can you confirm?

@droath yes, nearly.

Please note that
🐛 Unable to edit existing extra field or render any public site pages Active replaces
$this->getEntityTypeId(),
while the MR here keeps it and adds $this->getBaseEntityTypeId().

I think we should use this issue to check the result of 🐛 Unable to edit existing extra field or render any public site pages Active and see what it returns for bundleable and for non-bundleable entities to be sure it's totally correct yet.

My assumption is, that 🐛 Unable to edit existing extra field or render any public site pages Active does it correct, but we should check. Best would be to implement a kernel test?