- Issue created by @rkoller
- 🇩🇪Germany jan kellermann
jan kellermann → made their first commit to this issue’s fork.
- 🇩🇪Germany jan kellermann
- We split up the list (enabled services / disabled services).
- You can change the order of enabled services.
- you can enable or disable via checkboxPlease review and feedback.
- 🇩🇪Germany rkoller Nürnberg, Germany
Sorry took a little longer than anticipated, but my eye problems have flared up again, making longer text where you have to focus a bit cumbersome. I have taken a look at MR199 and played around with the merge request. I’ve noticed a few things:
- It looks like there is some additional padding between the
Enabled services
heading and its table underneath - that way the heading looks pushed towards theAdd service
button and the gap between the heading and the table is way bigger for theEnabled services
compared to theDisabled services
. It is probably due tomargin-block-start
within the.tabledrag-toggle-weight-wrapper
class selector. I suppose due to the fact that the other pages that are using the enabled/disabled pattern don’t have the option to sort in consequence they also have don't have theShow row weights
link on top of the table, and the div that is containing that link has that margin causing the larger gap. - The drop buttons in the
Operations
column are way bigger than usual - they look like twice the height compared to the drop buttons on for exampleadmin/structure/display-modes/view
,admin/structure/view
, oradmin/content
. - The status checkbox pattern for enabling and disabling services works as expected, but it has a few downsides.
- It is introducing a new pattern for handling the enabling and disabling of services, that is breaking with the existing one users are already familiar with - the other pages are using an
Enable
andDisable
options on the drop buttons in theOperations
column. - With checkboxes in place you have one additional click for saving the configuration, after selecting/checking all the services you want to enable or disable.
- Those status checkboxes make you, the user, think. Depending on what you are trying to change, for disabled services you want to enable you might catching yourself thinking do i select the services to enable by ticking them, while the other way around if you want to disable services and you are still in that “selection mindset” you might leave those services checked you want to disable. Also due to the fact that the position of the service is only changed when the save button is clicked you might have both sections with checked and unchecked services. The cognitive load is high that way. :/
Save configuration
button label and theStatus<code> column header are decoupled semantically from the section headings <code>Enabled services
andDisabled services
.- And finally the width of the columns differs between the two tables.
- It is introducing a new pattern for handling the enabling and disabling of services, that is breaking with the existing one users are already familiar with - the other pages are using an
- If you enable or disable all available services, either way you are getting
No services have been created yet.
. This is sort of inaccurate since Klaro is shipping with 23 services by default.
In the following a few suggestion how to tackle the aforementioned points:
about point 1: If possible I would reduce the margin between the
Enabled services
heading the associated table.about point 2: The other pages using the enable/disable pattern are using the extra small variant size for drop buttons from the Drupal Design System. I would suggest to stay consistent in regard to the styling. →
about point 3: I would suggest to follow the pattern the other pages with the enable/disable pattern are using. Remove the status column and adjust the width of the remaining columns in-between the two tables. On the drop buttons of the
Enabled services
section, keepEdit
the default option and add aDisable
option as secondary action. In theDisabled services
section makeEnable
the default option on the drop button and moveEdit
to the secondary actions. If you enable a disabled service it is directly moved to the enabled services section, same as the other way around.
The only slightly “odd” detail about that pattern is having those handles for changing the order of enabled services by dragging them vertically. My first impulse was testing if it would be possible to disable services by drag and drop. But it was clearly communicated that dragging a service to a different section doesn't work/is not intended AND the disabled services section doesn't have those handles.about point 4: Uncertain if it might be too granular, but the most accurate approach would be to check if there are no services created yet and then show
No services have been created yet.
in the enabled as well as the disabled services section. If there are services created, and none of them is enabled use something likeThere are no enabled services.
in the enabled services section, if none of them is disabled use something likeThere are no disabled services.
in the disabled services section. - It looks like there is some additional padding between the