views data doesn't work with bundle fields and produces a warning

There is already very little support for base fields, per documentation → and 📌 Improve views support for date recur base fields Active .

I assume this is what you mean by "bundle fields" == "base fields".

Code is useful if you disagree.

This may be closed as a dupe.

> I assume this is what you mean by "bundle fields" == "base fields".

No, bundle fields are fields which are defined in code but are not base fields. I wrote an overview here: http://www.noreiko.com/blog/defining-bundle-fields-code

These still might fall in a camp just like base fields do. As they are distinctly non-config derived fields.

Considering lumping "bundle" into the work that needs to be done for "base" fields.

Unfortunately it hasnt come up as a requirement in all these years, code is welcome.

> Considering lumping "bundle" into the work that needs to be done for "base" fields.

That's going to be complicated, because the way this module declares views data is:

1. Rely on hook_field_views_data() to declare the field data -- but hook_field_views_data() is only invoked for config fields
2. Build on top of the hook_field_views_data() stuff in hook_field_views_data_alter()

Hence the warning -- hook_field_views_data_alter() doesn't find what it expects.

Adding the basic data for bundle fields is babysitting the core issue 🐛 [PP-1] bundleFieldDefinitions() are not added in EntityViewsData Needs work .

I think the best thing here would be to add an isset() check and not assume $data[$fieldTable] is present.

Revisiting this, as the workaround I added to Finders Events turns out to cause problems of its own.

This module's views data code in DateRecurViewsHooks is catering for both base fields and config fields.
Given the lack of support for bundle fields in core Views, it shouldn't babysit and try to support bundle fields.

However, it's accidentally treating bundle fields as base fields because of these checks:

> if ($field instanceof BaseFieldDefinition) {

These will fail with modules that use a BundleFieldDefinition class to define bundle fields. This is found in Commerce and also in Entity module -- https://git.drupalcode.org/project/entity/-/blob/8.x-1.x/src/BundleField...

Calling isBaseField() is the right way to check for this instead. MR coming.

Uploading a patch on 3.8.x so it can be used on D10.