- Issue created by @jessebaker
- First commit to issue fork.
- 🇺🇸United States bnjmnm Ann Arbor, MI
I updated the steps to reproduce and added a failing e2e test that admittedly does not follow the exact steps as summarized, but still runs into the problem. In the test, it fails due to an error vs a non-passing assertion because the pile of Olivero assets include navigation JS that assumes certain elements are present and it errors when those elements aren't found.
- Merge request !415#3485842: Unwanted Olivero assets being loaded from core/drupal.ajax dependency → (Merged) created by bnjmnm
- 🇺🇸United States hooroomoo
Ok found from comment under
experience_builder_library_info_alter
and previous MRs it's because of Drupal.ajax bringing in Drupal.message that brings in Olivero assets but because the hooks run after a cache clear the current workaround that unsets the drupal.message library isn't getting triggered if a page that adds the library is visited first? - 🇺🇸United States bnjmnm Ann Arbor, MI
Re #6 Yep that's what it looks like.
cache_discovery
- cidlibrary_info:olivero
is the culprit. If this cache item is first generated when the XB UI loads, the$route_name === 'experience_builder.experience_builder'
condition is true and the library info cache will omit the extra assets. I suspect when that scenario happens then Olivero risks having some assets missing, but I haven't confirmed this. - 🇳🇱Netherlands balintbrews Amsterdam, NL
I think @bnjmnm would be the best person to review the solution.
- 🇺🇸United States bnjmnm Ann Arbor, MI
I can't codeowner-signoff because I provided the initial commit with the test, but this solution is AOK - it gets around having to use the libraries info alter hook that is sensitive to the first page visit. What's there is sorta workaroundy, but not moreso than what was removed, and it stops this bug from happening.
- First commit to issue fork.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Wow, 📌 Replace custom weights with dependencies in library declarations; introduce "before" and "after" for conditional ordering Needs work strikes again! 😬 I first commented on that core issue … 11.5 years ago 😮💨
Automatically closed - issue fixed for 2 weeks with no activity.