Update legacy themes

There are two possible approaches that I think would work for themeing the front end:

1. Minimalist: add module CSS via libraries.yml for just the LMS elements, including course navigation block. These styles could then be overwritten by the end-user's custom site theme.
    
2. Full site: create a custom subtheme of one of the popular Bootstrap themes that applies to the whole site and creates a full LMS site experience, á la Opigno. This could then be customized by the end-user to suit their site needs.

These two approaches are not mutually exclusive. Just wondering if I take on the front end design which would be most helpful to focus on first.

What do you think of using a new generation theming approach with UI Suite Initiative (that is leveraging SDC and new Icon framework) ?

Many themes are already available like :

• UI Suite Bootstrap
• or UI Suite DaisyUI

We could support the use of our ecosystem and also be available for a discovery meeting !

Don't hesitate to contact us. We are available on slack at #ui-suite-initiative ;)

You could also have a look at our last presentation of UI Patterns 2 @Drupalcon Barcelona for better understanding of the approach (regarding Components) --> https://www.youtube.com/watch?v=75wRtmpczOM&list=PLtGBRax0Lj4TXurFMpnd-y...

I'd go for absolutely minimalist approach here, without even adding any css, just convert those templates to something more simple or even completely drop them and for example use Core #item_list in place of lms_lp_step_module_activity.
As little and as clean as possible here and any work in an ecosystem theme to make this awesome.

With UI Suite modules you have the ability to connect data and design directly in the UI, so only config threw manage display, layout builder, views, block layout, ...

When it's not possible (10-20% of the time) to "site build" you can use UI Patterns in code with twig include function or in php with drupal_render function.

Seems like there are two issues, the original intent was what to do with the lms_lp_step_* themes and I agree that they should just be dropped. Using #item-list seems like a great solution.

Then there is the question of whether the LMS project should offer a whole-site theme so it can be more-or-less a drop-in replacement for Opigno. Maybe this should be discussed in a separate issue? The more I think about it the more it seems to me that it's not necessary and should be left in the hands of each site builder.

On the other hand, exposing all of the LMS elements for easy styling by front-end designers would be a kind thing to do. Maybe I'm too old-school but my first instinct is to include a CSS file in the module that categorizes and lists all of the elements for styling, and allows front-end designers to just copy those into their site theme for customization.

I'm also getting up to speed on UI Suite, it may take me a while to wrap my head around it!

I would also go for the minimalist approach. It gives more flexibility. The module would have the functionality and really basic css. And separately we could provide themes (one type) /ui suite (multiple layouts/colors in one theme) solutions. Recipes come to mind realizing that.

Seems like there are two issues, the original intent was what to do with the lms_lp_step_* themes and I agree that they should just be dropped. Using #item-list seems like a great solution.

I'm very +1 to this and it's what I think we should do in this issue. We can add theme suggestions so they're easier to customise.

Then there is the question of whether the LMS project should offer a whole-site theme so it can be more-or-less a drop-in replacement for Opigno. Maybe this should be discussed in a separate issue? The more I think about it the more it seems to me that it's not necessary and should be left in the hands of each site builder.

I think this is worth an issue to discuss, however my inclination would be that we should try to provide UI suite components and think towards compatibility with experience builder and the theme builder that eventually will come with that, as opposed to developing a theme as such.

Neither me nor @graber have any short or medium plans for a distribution, I think there is a place for a recipes-based distribution for Drupal LMS eventually (along similar lines to Drupal CMS), but we don't currently have a client who would need that and aren't planning to try to sell Drupal LMS as a 'product' or anything, so it's very far down the list of priorities for us. Although if someone else wanted to get that up and running it could be interesting.

I think we should continue with the current approach here (a render array with theme suggestions) but open a follow-up to either convert to SDC/UI suite or add an additional block that supports that once there's something functional. There's quite a lot to think about in terms of what data is available (whether activities are answered, need grading, have been graded, the score, whether lessons are finished/passed/failed/in progress) so for me at least it would be easier to think about how to wire that all up to SDC/Icon API etc. when there's something working to test/compare against.

Switched over to using #lazy_builder for each lesson - this allows us to cache everything except the current lesson I think.

Also added score/max-score and evaluation information to the activities data.

Made the following changes:

1. Got rid of the 'status' concept in the render array entirely, everything reflects the underlying data now (answered or not, evaluated or not, passed or not etc.) I think this is a lot easier to follow and should be less error prone in general.

2. The list items for the lessons can't get the classes out of the #lazy_builder so doing that up-front in the block builder, this means the #lazy_builder is for building the activities links now.

3. Various clean-up and test fixes etc - all green again.

I think this is at the point we could probably merge it and tidy/improve things later so moving back to needs review.

Went through and fixed some of the nits I had on the original MR. I think that's all I've got for here.

Opened 📌 [PP-1] Convert course navigation block to SDC Active

Thanks all, merged.