- Issue created by @harsh.behl
- Status changed to RTBC
3 months ago 9:11am 21 January 2025 - 🇮🇳India divyansh.gupta Jaipur
I have reviewed the changes and the changes looks good to me and are made as expected by the issue because now if the key is missing then the metadata will not be checked,
Thus moving it to RTBC+! - 🇮🇹Italy mondrake 🇮🇹
1) please target branch 3.2.x
2) please add automated tests to prove the issue
3) since we accept that a $key can be NULL (see method signature), I do not think this is acceptable... - 🇺🇸United States veronicaSeveryn
I have tested this patch.
It does solve the issue with exceptions logging, but it will break derivatives generation in other instances.
For example, for "imagemagick_identify" metadata the key can be empty, otherwise, if we skip, it doesn't generate metadata and the image derivative generation fails later.