Incorrect caching of nodes with access denied pages

Updated issue summary in #1.

The patch caches separately for every user. Could it use the user.roles.role_name context instead?

This is "needs work" for #5.

Regarding Comment #5 🐛 Incorrect caching of nodes with access denied pages Needs review : no, unfortunately not without more logic. The access rules for viewing webforms can be defined both per user and per role.

Let's see if the tests pass with additional user context.

jrockowitz → changed the visibility of the branch 6.3.x to hidden.

The patch caches separately for every user. Could it use the user.roles.role_name context instead?

If we added an optional $operation parameter to \Drupal\webform\Element\Webform::buildAccessDenied we could add cache context based on the webform's access rules. In most cased I think people are using roles and permissions.