- Issue created by @rhovland
- Merge request !29#3485160 by rhovland: Change template from using unstyled table to using divs β (Open) created by rhovland
- First commit to issue fork.
- π©πͺGermany Anybody Porta Westfalica
I think semantically, we should use a list? (
<ul><li>
) - πΊπΈUnited States rhovland Oregon
Normally I'd agree except in the vast majority of cases there will be only one gift card redeemed (if multiple is even enabled on the site). Additionally using a list will introduce usually undesirable visual changes that would then have to be themed away by site builders. While the module could provide some css to hide the list bullets, now we'd have to maintain CSS in the project where there was none before.
- π©πͺGermany Anybody Porta Westfalica
Mhm yeah I understand that, still I'm afraid a list should be a list semantically.
At least we should add span's with classes to be able to grab elements in CSS?