[CI] Introduce a separate stage for unit tests

I like this in principle, but worry it will be harder to find the test results summary. Currently you need to go to the child job so see that, now you may need to go to two child jobs. I wonder if there's any way to bubble up the test results to the parent job.

Added parallel:matrix to be able running unit test on multiple PHP versions.

This is highligthing PHP 8.4 deprecations, for instance.

Latest commit to the MR adds a job to run tests for Drupal components directly in PHPUnit, including code coverage report.

Probably needs to be spun off to a follow up, just wanted to showcase it.

Removed #7.

@mstrelan yeah I kinda agree that finding test results is already quite tricky when you don't know where to look, and this makes it more complicated. There is no way to surface child pipeline results in a parent yet, see https://gitlab.com/gitlab-org/gitlab/-/issues/363019

Question how come phpunit had to be updated in composer?

That one is the composer.json of the PHPStan rules testing, not core's. That is separate from the rest to allow independent testing from core. Being independent, it's also not bound to core's dependencies and it happens PHPUnit 11 can be used for this without any of the hurdles that core has: 📌 [PP-1] Make PHPStan rule testing use PHPUnit 11 Postponed . Here's is not strictly necessary, but I made that change to 'force' the PHPStan rule testing job to run as that job is based on changes in the PHPStan rules directory.

Think I see what @mstrelan and @longwave are talking about now. Anyway to get the results https://git.drupalcode.org/issue/drupal-3484966/-/pipelines/335642 to the rest of the tests?

Not until upstream gets #9 done, I am afraid.

Should this be postponed or is there a larger gain to be add with moving it out?

The gain I see is to be able to test future versions of PHP through matrix (and potentially PHPUnit, too) on unit tests only, earlier than the rest of the test suite, and highlight deprecations in advance without failing overall testing job.

For example, PHP 8.4 is going to be delivered the day after tomorrow, and there is not yet a regular job testing with it AFAICS.

That does seem worth it, not 100% I can make the call but maybe @longwave?

Also the current MR needs a manual rebase.

To have a proper matrix we need to unify image names too

Going to go on a limb here

Per #17, adjusted after commit of ✨ Release ubuntu images for PHP 8.1 and 8.2 Active . Leaving at RTBC.

After 📌 upgrade prophecy to 1.20 Active , unit tests pass on PHP 8.4 so it's no longer necessary to let them fail in the job

Just found that instead of running all tests on both 8.3 and 8.4, actually the tests get spread across the two.

added suggestion and asked why phpunit-11 is not follow-up?

--ci-parallel-node-* args in run-tests.sh conflict with gitlab matrix. Since we do not need to break out unit tests in multiple jobs, removed the args.

@andyoost re #23 see #11.

PHPUnit version for PHPStan testing is rather irrelevant, but I removed from the MR to make things more straightforward. Since a change in the PHPStan directory is needed to show how the test job would trigger, I changed a comment in a test class instead.

There's a list of deprecations for PHP 8.5 already https://wiki.php.net/rfc/deprecations_php_8_5

So it makes sense to catch them in core or via https://github.com/php/php-src/pull/10050

#27 when there will be a PHP 8,5 docker image available, we can easily add it to the job matrix here, allowing failures. That will help showing deprecations for 8.5 while keeping the entire pipeline green.

The last PHP 8.4 fix been commited, so the only question is should we add a daily or on-commit run via 📌 [PP-2] Add core testing withPHP 8.4 Postponed

I find it ready!

PHPUnit 11 has own meta issue 🌱 [meta] Support PHPUnit 11 in Drupal 10 Postponed

It would be great if we can define the matrix in the root .gitlab-ci.yml file - means all the php version stuff is in one place.