[1.0.x] Paragraphs Clipboard

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

1. Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml paragraphs_clipboard/

FILE: /paragraphs_clipboard/paragraphs_clipboard.module
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
  59 | ERROR | The array declaration extends to column 82 (the limit is 80). The array content should be split up over multiple lines
 171 | ERROR | The array declaration extends to column 82 (the limit is 80). The array content should be split up over multiple lines
----------------------------------------------------------------------

FILE: /home/vishalkadam/DRUPAL-REVIEW/paragraphs_clipboard/modules/layout_paragraphs_clipboard/layout_paragraphs_clipboard.routing.yml
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 11 | WARNING | The administration page callback should probably use "administer site configuration" - which implies the user can change something - rather than "access
    |         | administration pages" which is about viewing but not changing configurations.
----------------------------------------------------------------------

FILE: /home/vishalkadam/DRUPAL-REVIEW/paragraphs_clipboard/src/Plugin/Field/FieldWidget/ParagraphsClipboardWidget.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 26 | ERROR | The array declaration extends to column 94 (the limit is 80). The array content should be split up over multiple lines
----------------------------------------------------------------------

FILE: /home/vishalkadam/DRUPAL-REVIEW/paragraphs_clipboard/tests/src/Functional/ParagraphsClipboardTest.php
----------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------
   6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\field\Entity\FieldStorageConfig.
  51 | ERROR | [ ] The array declaration extends to column 96 (the limit is 80). The array content should be split up over multiple lines
 104 | ERROR | [ ] The array declaration extends to column 96 (the limit is 80). The array content should be split up over multiple lines
 109 | ERROR | [ ] The array declaration extends to column 96 (the limit is 80). The array content should be split up over multiple lines
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

2. FILE: paragraphs_clipboard.module

/**
 * @file
 * This is the module to copy and paste paragraph content.
 */

FILE: modules/layout_paragraphs_clipboard/layout_paragraphs_clipboard.module

/**
 * @file
 * This is the module to copy and paste paragraph content.
 */

The usual description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.

3. FILE: src/ParagraphsClipboardService.php

  /**
   * Service constructor.
   *
   * @param \Drupal\Core\TempStore\PrivateTempStoreFactory $temp_store_factory
   *   The temp store factory.
   * @param \Drupal\Core\Entity\EntityTypeManagerInterface $entity_type_manager
   *   The entity type manager.
   * @param \Drupal\Core\Entity\EntityRepositoryInterface $entity_repository
   *   The entity repository.
   */
  public function __construct(PrivateTempStoreFactory $temp_store_factory, EntityTypeManagerInterface $entity_type_manager, EntityRepositoryInterface $entity_repository) {

FILE: modules/layout_paragraphs_clipboard/src/Controller/CopyClipboardController.php

  /**
   * {@inheritDoc}
   */
  public function __construct(LayoutParagraphsLayoutTempstoreRepository $tempstore, ParagraphsClipboardService $clipboard_service) {

FILE: modules/layout_paragraphs_clipboard/src/Controller/PasteClipboardController.php

  /**
   * {@inheritDoc}
   */
  public function __construct(

The documentation comment for constructors is not mandatory anymore, If it is given, the description must be Constructs a new [class name] object. where [class name] includes the class namespace.

Thank you @vishal.kadam for the review.
I've resolved all the suggestions and pushed them to the 1.0.x branch.
Regarding namespaces, I left them out of constructor doc comments to keep within the 80-char limit.

Rest looks fine to me.

Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.

I am changing priority as per Issue priorities. →