Show title on notice dialog optional

Came across this since I got penalized by lighthouse for not having a title or aria-label on the dialog:

I think you should be able to set a title but not show it. However looking at the code upstream that is currently not possible. If !showNoticeTitle then no title is shown (link). This is covered in this issue upstream: https://github.com/klaro-org/klaro-js/issues/521

I also added a reference to this issue at 🌱 [Meta] Improve the accessibility of the Klaro module Active .

Thank you for your feedback.

We were not aware of this error message.

I have created a merge request that always displays the title, but hides it visually by default (it can be displayed optionally). So it should work as a label for the dialog.

I changed category and priority.

Please test and provide feedback. Thank you very much!

Bump. Updated fork, ready to review. Would be great to have this issue reviewed and merged for next release.

I reviewed the issue and the work already done.

I found only one thing that still needs work:

If I set the option Styling->Show title in notice dialog. The title will still not be displayed in the notice as the css that hides it still applies.

I´ll set the status to needs work and will try to make a fix now

Fixed the flaw i mentioned above, setting back to needs review. But from my side this is looking very good right now

Thank you for issue, feedback and testing.

I merged this MR.

Automatically closed - issue fixed for 2 weeks with no activity.