- Issue created by @jan kellermann
- 🇩🇪Germany sascha_meissner Planet earth
I have mixed feelings as the root cause is obviously a bug in the js library as described in the bottom of this issue here https://github.com/klaro-org/klaro-js/issues/503 and we cannot be sure if the area-labelledy will be just ommited when showNoticeTitle=false or if they also go with visually hiding the title when fixing this eventually. So i would propose to support the option showNoticeTitle (not set the default to true though) and the label for the notice title in the settingsform/config, but just remove the area-labelledby attribute in the already existent "accessibilityducktape" in the js-file of this drupal module if showNoticeTitle=false.
This way it would be easier to adopt to a upstream library change imho + we wouldnt have to care of an updatehook and css.
? - 🇩🇪Germany jan kellermann
Sascha, you are right that this is an upstream issue. But we have to solve this. As quick solution I just remove the wrong attribute for this single element.
After merging we can still leave this issue open for the "big solution".
Please review.
- 🇩🇪Germany jan kellermann
FYI: Issue opened on klaro-org: https://github.com/klaro-org/klaro-js/issues/521
- 🇩🇪Germany jan kellermann
I moved the introduction of a new config item for notice dialog title to new ticket #3484844.
- 🇩🇪Germany jan kellermann
I merged this issue. thank you all. See you later on #3484844.
-
jan kellermann →
committed c299c463 on 3.x
#3483896: Fix broken ARIA reference.
-
jan kellermann →
committed c299c463 on 3.x
Automatically closed - issue fixed for 2 weeks with no activity.