"(bool) $fieldValues->orderable" is not save enough

Created on 30 October 2024, 6 months ago

Problem/Motivation

$fieldValues->orderable

Currently, returns "1" as a string. I am scared, that !orderable might return "0" as a string, so we should use empty() here instead.

Steps to reproduce

Proposed resolution

Use empty() instead.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

1.0

Component

Code (commerce_product_availability)

Created by

🇩🇪Germany Grevil

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024