docs for EntityTypeInterface::getBundleOf() should say entity type *id*

The @return needs changing too IIRC.

BTW remember to update the issue status when you make a MR.

Hey @joachim,

Apologies, was waiting for the pipeline to pass/fail before changing and requesting code review on this! Could i confirm the workflow process? Is it When i start working on an issue, i assign to myself and leave as active? Or change to needs work?

Also, i believe MR !10007 is ready for review. There was a failed test but that seems unrelated to this issue, so im hoping a rerun of that test will fix it.

Thanks.

> Apologies, was waiting for the pipeline to pass/fail before changing and requesting code review on this!

That's a fair point!

> Is it When i start working on an issue, i assign to myself and leave as active? Or change to needs work?

You can assign to yourself when you start work on it, as a precaution to avoid someone else working on it too.

'Needs work' is usually set by a reviewer, or by a test failure. Though if you implemented a partial fix and had to stop, you could unassign yourself and set it to 'needs work'.

MR looks good, setting to RTBC!

Backported to 10.3.x as a docs fix.

Committed and pushed 6c280ff83db to 11.x and fb2c558d38e to 11.1.x and 0b914df64da to 11.0.x and d648873d628 to 10.5.x and db062458cf3 to 10.4.x and 387eccd4a65 to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.