Show a confirmation message on successful Coupon redemption

Alright, this works after the first form is submitted. Unfortunately, it doesn't work for any AJAX calls yet. Furthermore, I can't seem to get the message to display. I'll have a deeper look tommorow.

Great, it already improves the situation once a coupon code has been entered.

Alright, works perfectly now! Including any ajax calls :)

Please review!

Added a temporary patch for the time being.

Test needs to be fixed

Patch has a bug! Use statement for TranslatableMarkup is missing!

I'll fix that now.

Ah I see it's not a bug in the patch, the patch is for 3.0.x and applies for 2.x but in 2.x there's no such use statement... -.-

So I'll create a separate MR for that.

Patch for 8.x-2.x attached!

grevil → changed the visibility of the branch 3.0.x to hidden.

I don't think a separate branch and MR for 2.x isn't needed, as all of the work goes into 3.x now.

grevil → changed the visibility of the branch 3484265-show-a-confirmation-2.x to hidden.

No idea, everything works as intended, but the test failures are definitely related to these issues changes, but I don't quite understand what's wrong...
Everything works great and as expected, but inside the tests, the error "Unable to complete AJAX request" always appears. This is caused by the new "ajaxRefreshForm()" method. But, even if that method is ENTIRELY EMPTY and only calls the parent "ajaxRefreshForm()" method we get the exact same failure. I even tried to go back to the old [get_called_class(), 'ajaxRefreshForm'], but that breaks the ajax request outside the tests as well (and the test also fail with the same error message, even if it shouldn't).

My first thought was, that we have to open the coupon code wrapper before we press the "ApplyCode" button, but inside the tests there is no wrapper. I also partially removed changes from this issue, to see what causes the failure, but it is definitely related to the new "ajaxRefreshForm" method.

Missed a return statement....

Well tested and tests are green now. This is a nice improvement, so happy to RTBC :)

Static patch attached until this is merged!

Static patch for 3.0.x for the time being.

I generally dislike fixes that make assumptions about pane IDS or pane placement... Additionally, this is not using dependency injection for the messenger and direct \Drupal calls() are generally not a good practice.

"applyCoupon()" is static, so I can't use the messenger service inside that method, unfortunately.

Ok, this should be it! Honestly, I have no idea, why I even added the "AjaxRefreshForm" method, the changes done in the CheckoutPane class already solves the issue.

Maybe I had caching issues and didn't realize it. Still works as expected, and we don't check for a specific pane placement!

Please review once again!

Ok so we are still not injecting the messenger. We probably should remove the constructor and do the injection from the create() method. This would be considered as a BC for some people, but I don't like the alternative of conditionally setting the messenger if not injected.

Also, I believe this is still a risk of showing a success message despite the coupon being removed on refresh. It's curious that we aren't doing like in the processor, i.e. validating the coupons reference... But this is probably out of scope for this issue:

$constraints = $coupons_field_list->validate();.

@jsacksick you saw that applyCoupon() is a static method? How would DI work there?

Apologies... This is what I see when reviewing the MR:

As you can see, very little "context"... Merging this.

All good, so we're not total idiots, that's reassuring 😁

Thank you!!

Automatically closed - issue fixed for 2 weeks with no activity.