Handle Missing $data['invalidations'][0] in Invalidation Check

Created on 29 October 2024, 3 months ago

Problem/Motivation

The problem is that if $data['invalidations'] does not have an element at index 0, the token replacement will not work, even if there are other elements in $data['invalidations'].

Steps to reproduce

Add an HTTP Bundled Purger -> then set the Type to Tag -> set the body to [invalidations:separated_comma]
Add an HTTP Bundled Purger again -> then set the Type to Path -> set the body to [invalidations:separated_comma]

Proposed resolution

We need to use reset($data['invalidations']) instead of $data['invalidations'][0] for the condition.

🐛 Bug report

Status

Active

Version

3.6

Component

Code

Created by

🇻🇳Vietnam hoanglv

Live updates comments and jobs are added and updated live.

Merge Requests

!51Handle Missing $data['invalidations'][0] in Invalidation Check
Open
🇮🇳India divyansh.gupta
updated 20 days ago

Comments & Activities

Issue created by @hoanglv
Comment 3 months ago →
🇻🇳Vietnam hoanglv
Assigned to divyansh.gupta
Comment 20 days ago →
🇮🇳India divyansh.gupta Jaipur
Merge request !51Issue #3484260: Handle Missing $data['invalidations'][0]. → (Open) created by divyansh.gupta
Pipeline finished with Success
20 days ago
Total: 1387s
#390704
Comment 20 days ago →
🇮🇳India divyansh.gupta Jaipur
Hello @hoanglv,
Applied your patch and the changes looks good to me because this can solve the error as by using reset($data['invalidations']), the code will check if there is at least one element in $data['invalidations'], regardless of the key structure.
Please review.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024