After ban, user receives unread message notifications

I am also experiencing a similar situation. in my case, only with two users. When the banned user 2 sends a message to "banning" user 1, the user 1 gets the new message notification.

For now I think we should use the same approach as in the threads notification and filter out messages in threads that have the banned user.

I don't think we should remove the "banning" user 1 from the notifications. Because if that users removes the ban, he should get access again to the threads.

I have created a MR with a fix.

But I let the issue in status "Needs work".
The tests are failing (but I don't think it's related with my changes).
We need to test also if like this the notifications by email are also prevented.
Maybe some tests?

Tests were falling due to #3488863
Yes, I think we need to provide a test for this issue.

I have enhanced the existing Functional JavaScript test testNotifications() to test a banned user.
Moving to Needs review.

We've opened the 4.x branch. Each new fix/feature should be be filled agains the highest branch. After merging we'll decide whether it makes sense to backport to 3.0.x

I did the changes for 4.x. But it still needs the tests.

I put a test in place for this. It's ready for review.

Merged in 4.x. Thank you!

Now this needs some work to be backported to 3.0x.

Here is the MR for 3.0.x.
https://git.drupalcode.org/project/private_message/-/merge_requests/174

Thanks. Merged

Automatically closed - issue fixed for 2 weeks with no activity.

dxvargas → closed merge request !190