Restrict package_manager (and update_manager) behind a dev/prod toggle

Changing the release branch version to 11.1.x since 11.0.x is already out with releases to make things less confusing.

To support 📌 Prepare for package_manager in core Active we need to have package_manager in 11.1, or release very, very early 11.2 alphas. Very early 11.2 alphas affects the entire release process, so I think we should do this issue instead.

This means not removing package_manager from the 11.1.x branch which is what we'd normally do for an alpha-stability experimental module, and instead hiding package_manger via hidden.true in package_manager.info.yml.

We also said we'd put package_manager behind a dev/prod toggle but unfortunately ✨ Add a Production/Development Toggle To Core Needs work isn't done yet.

But.. for package_manager specifically, any arbitrary $settings key will do because it's going to be a temporary situation anyway until it's stable. So we can just do $settings['testing_package_manager'] = TRUE or whatever without worrying too much hopefully.

Then we need a hook_requirements('install') to prevent installation unless the setting is on, and a change record, and hopefully that's enough?

I think any arbitrary settings key is fine

One comment on the MR but otherwise looks great.

Tests are failing but I like this idea and the proposed approach. So consider this a soft RTBC when tests pass.

I think I fixed the tests. Let's see what the bot thinks.

Meanwhile, crediting @quietone for the initial work, @catch for the detailed reviews + input, and myself for trying to fix the tests...

Two very common random test failures but otherwise green. Moving to RTBC.

larowlan → closed merge request !10080

Committed to 11.x and backported to 11.1.x

Sweet, thanks!

I just published the CR ( https://www.drupal.org/node/3486019 → ) and set the "Introduced in version" to 11.1.0-beta1. Hope that's correct. Please edit if needed.

Thanks again,
-Derek

Automatically closed - issue fixed for 2 weeks with no activity.