- Issue created by @bnjmnm
- πΊπΈUnited States bnjmnm Ann Arbor, MI
Added a test module in the MR and found that the autocomplete inputs (which had been proven to work in the past but never got test coverage) no longer work due to the input now using the Radix TextField
component
. This component intercepts a few props, including className and applies them to the input's parent<div>
instead of the<input/>
and Drupal's autocomplete initializes based on the presence of.form-autocomplete
on an<input/>
element. - πΊπΈUnited States bnjmnm Ann Arbor, MI
Between this issue and π Confirm Semi-coupled form elements can work with State API visibility Active , if we want to continue using Radix we need to have a way to customize the attributes sent to the input elements within the component. I filed an issue with primitives about doing this with
Checkbox
, and if that is welcomed I'll do the same in Radix themes for theTextField
component - πΊπΈUnited States effulgentsia
This is a blocker for β¨ [PP-1] Make link widget autocomplete work (for uri and uri-reference props) Postponed .
- πΊπΈUnited States effulgentsia
If Radix doesn't accept the PR, is there a way we can accomplish it via
ref
? Does Radix already forward refs to the form element we'd want our attributes on? - πΊπΈUnited States bnjmnm Ann Arbor, MI
It can be done with a ref!
Updated MR on the way...
- πΊπΈUnited States effulgentsia
I think the MR looks great. Should we upgrade to React 19 and take advantage of the nicer syntax for refs?
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
#13: Let's not expand the scope here. π Opened π Upgrade to React 19 (and take advantage of the nicer syntax for refs Active for that βΊοΈ
Some discoverability and consistency remarks, plus I don't understand why test is being changed. I bet it's all trivial for @bnjmnm to address π
- πΊπΈUnited States bnjmnm Ann Arbor, MI
Feedback addressed and the Cypress memory issue was seemingly addressed by making the test module name shorter (???)
- Assigned to hooroomoo
- Status changed to Needs review
16 days ago 7:38pm 17 March 2025 - πΊπΈUnited States bnjmnm Ann Arbor, MI
@balintbrews approved this but it looks like we still need a semi-coupled owner to approve too> @hooroomoo seems like the best candidate for that
- πΊπΈUnited States bnjmnm Ann Arbor, MI
After a few days of e2e tests passing reliably, the autocomplete test introduced here began encountering the unpredictable+ambiguous "
We detected that the Electron Renderer process just crashed.
". So we can continue working without false-red-x's popping up, the autocomplete e2e test is bypassed on headless and the screenshot below shows that it is passing fine on headed.
-
bnjmnm β
committed f3f5dcb4 on 0.x
Issue #3481717 by bnjmnm, wim leers: Confirm Semi-coupled form elements...
-
bnjmnm β
committed f3f5dcb4 on 0.x
- π³π±Netherlands balintbrews Amsterdam, NL
bnjmnm β credited balintbrews β .
- πΊπΈUnited States bnjmnm Ann Arbor, MI
Merged. Thanks for the reviews everybody!
Automatically closed - issue fixed for 2 weeks with no activity.