Allow selecting client-side or server-side trimming

@maintainers: Would be great to get some feedback, if you understand and like the idea in general and if it's okay to put it into the main module as a setting within the formatter or if it needs to be a submodule!

The base functionality and test coverage is there now, PHPUnit seems to fail due to an unrelated test from a different commit.

Okay, perhaps the pipeline failure isn't that unrelated, I will take a look.

Pipeline fixed!

PHPStan is failing:

 ------ ---------------------------------------------------------------------------------------------- 
  Line   modules/smart_trim_client_side/tests/src/FunctionalJavascript/SmartTrimClientSideJSTest.php   
 ------ ---------------------------------------------------------------------------------------------- 
  21     PHPDoc type array of property                                                                 
         Drupal\Tests\smart_trim_client_side\FunctionalJavascript\SmartTrimClientSideJSTest::$modules  
         is not covariant with PHPDoc type array<string> of overridden                                 
         property Drupal\Tests\BrowserTestBase::$modules.                                              

Did a few adjustments and commented them for easier review. 1 Question is still open.

Last phpstan issue is unrelated.

@Grevil & @LRWebks: Could you please ensure all fixes here are also reported upstream (if the code was copied)? Please open a MR for that in a separate issue, if it has the same bugs.

Thank you!

@Grevil & @LRWebks: Could you please ensure all fixes here are also reported upstream (if the code was copied)? Please open a MR for that in a separate issue, if it has the same bugs.

The only upstream bug (missing token->replace variable initialization) IS fixed here. That's why I asked whether this is not too unrelated or not.

Okay I think separate issues should be opened for these upstream fixes. Quite self-explaining ones. So we have the discussion elsewhere.

Agreed!

Alright. Let's remove any unrelated changes and solve them inside an follow-up issue.

Alright, all done. LGTM!

I will create follow-up issues for the other issues found.

Great work guys, I'm so happy to see this soon. Wonderful addition to this wonderful and super useful module. I'm sure it will be widely used :)

First: 🐛 "More" Text doesn't support Tokens, even if it says it does. Active

Second: 🐛 Do not use "class" value on both "class" and "more_wrapper_class" Active