Contrib.social

Drupal 11 Compliance Issues

Open on Drupal.org →
Created on 16 October 2024, 6 months ago

Problem/Motivation

Drupal 11 compliance validated using the update status module and code inspection has found the following issues.

File: modules/contrib/layout_builder_block_sanitizer/tests/src/Functional/SanitizerTest.php
Line: 13
Drupal\Tests\BrowserTestBase::$defaultTheme is required.
See https://www.drupal.org/node/3083055 → , which includes recommendations on which theme to use.

File: modules/contrib/layout_builder_block_sanitizer/layout_builder_block_sanitizer.info.yml
Line: 4
Value of core_version_requirement: ^8 || ^9 || ^10 is not compatible with the next major version of Drupal core.
See https://drupal.org/node/3070687.

🐛 Bug report
Status

Active

Version

1.0

Component

Code

Created by

🇺🇸United States emptyvoid

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @emptyvoid
  • Comment 6 months ago →
    ananya.k
  • Comment 6 months ago →
    ananya.k

    I have made some changes. Please refer to attached patch.

  • Comment 6 months ago →
    🇺🇸United States emptyvoid

    Created a patch addressing all of the items sighted.

  • Status changed to Needs work 2 months ago
  • Comment 2 months ago →
    🇺🇸United States pcate

    I applied patch #4 and ran the upgrade status module scan on the module. The following errors were found affecting Drupal 11 compatibility.

    2 errors found.

modules/contrib/layout_builder_block_sanitizer/src/LayoutBuilderBlockSanitizerMa
nager.php:
| 115  | Call to deprecated method get() of class
Drupal\layout_builder\SectionComponent. Deprecated in
drupal:10.2.0 and is removed from drupal:11.0.0. Additional
properties should be gotten via ::getThirdPartySetting().
 |
| 136  | Call to deprecated method get() of class
Drupal\layout_builder\SectionComponent. Deprecated in
drupal:10.2.0 and is removed from drupal:11.0.0. Additional
properties should be gotten via ::getThirdPartySetting().
  • Merge request !2applied @emptyvoid patch and replaced get method with getConfiguration → (Open) created by pcate
  • Comment about 2 months ago →
    🇺🇸United States pcate

    I created a MR with @emptyvoid patch. I also replaced the $section_component->get('configuration') call with $section_component->getConfiguration() to fix the deprecation warning.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024