- Issue created by @plopesc
- πͺπΈSpain plopesc Valladolid
Recipe created and tests are green. Ready for review.
- πΊπΈUnited States phenaproxima Massachusetts
I'm sort of unclear on why we need this to be its own recipe. It basically doesn't do anything but install the Navigation module. Where was this decision made? Did @pameeela (product owner) sign off on this, or request it?
IMHO, this makes more sense as part of the existing drupal_cms_admin_theme recipe, rather than its own.
But at the very least, the issue summary needs to be updated with a fuller explanation about the rationale for this.
- πΊπΈUnited States phenaproxima Massachusetts
I just looked at HEAD and...er...the drupal_cms_admin_theme recipe already enables Navigation!
So yeah, I really need to know why this should be moved to its own recipe before I merge this. I'm happy to assign ownership of drupal_cms_admin_theme to the appropriate track leads, if that's all that's really wanted here.
- π¦πΊAustralia pameeela
Navigation is already being enabled in the admin theme recipe (hence why it's available in Drupal CMS now): https://git.drupalcode.org/project/drupal_cms/-/blob/0.x/drupal_cms_admi...
So this already works, and I agree this probably doesn't need a separate recipe, but I am not sure if there is context I am missing?
- πͺπΈSpain plopesc Valladolid
We agreed to create an scaffolding recipe for he Navigation Track during the kickoff call we had on 11/10 with Cristina and Tim.
The aim was to provide some scaffolding that would allow to provide more complex navigation configs in the future.
If you feel that we should reuse the existing
drupal_cms_admin_theme
, that would work for me.In that case, renaming it to
drupal_cms_admin_ui
would be more appropriate, I think, given that Navigation bar is not present only in the admin theme, but also in the main theme. - πΊπΈUnited States phenaproxima Massachusetts
Okay, I'll talk to Tim about this and come back with a plan of action.