Create Base Recipe for Navigation

Created on 14 October 2024, 2 months ago

Problem/Motivation

Create base recipe for Navigation.

Proposed resolution

Create base recipe for Navigation.

Remaining tasks

Review & merge.

User interface changes

None.

API changes

None.

Data model changes

None.

πŸ“Œ Task
Status

Active

Component

Track: Navigation

Created by

πŸ‡ͺπŸ‡ΈSpain plopesc Valladolid

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @plopesc
  • Pipeline finished with Canceled
    2 months ago
    Total: 131s
    #309410
  • Pipeline finished with Failed
    2 months ago
    Total: 61s
    #309412
  • Pipeline finished with Failed
    2 months ago
    Total: 427s
    #309413
  • Pipeline finished with Failed
    2 months ago
    Total: 590s
    #309415
  • Pipeline finished with Failed
    2 months ago
    Total: 610s
    #309416
  • Pipeline finished with Success
    2 months ago
    Total: 630s
    #309486
  • Pipeline finished with Success
    2 months ago
    Total: 635s
    #309485
  • πŸ‡¨πŸ‡¦Canada m4olivei Grimsby, ON
  • πŸ‡ͺπŸ‡ΈSpain plopesc Valladolid

    Recipe created and tests are green. Ready for review.

  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    I'm sort of unclear on why we need this to be its own recipe. It basically doesn't do anything but install the Navigation module. Where was this decision made? Did @pameeela (product owner) sign off on this, or request it?

    IMHO, this makes more sense as part of the existing drupal_cms_admin_theme recipe, rather than its own.

    But at the very least, the issue summary needs to be updated with a fuller explanation about the rationale for this.

  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    I just looked at HEAD and...er...the drupal_cms_admin_theme recipe already enables Navigation!

    So yeah, I really need to know why this should be moved to its own recipe before I merge this. I'm happy to assign ownership of drupal_cms_admin_theme to the appropriate track leads, if that's all that's really wanted here.

  • πŸ‡¦πŸ‡ΊAustralia pameeela

    Navigation is already being enabled in the admin theme recipe (hence why it's available in Drupal CMS now): https://git.drupalcode.org/project/drupal_cms/-/blob/0.x/drupal_cms_admi...

    So this already works, and I agree this probably doesn't need a separate recipe, but I am not sure if there is context I am missing?

  • πŸ‡ͺπŸ‡ΈSpain plopesc Valladolid

    We agreed to create an scaffolding recipe for he Navigation Track during the kickoff call we had on 11/10 with Cristina and Tim.

    The aim was to provide some scaffolding that would allow to provide more complex navigation configs in the future.

    If you feel that we should reuse the existing drupal_cms_admin_theme, that would work for me.

    In that case, renaming it to drupal_cms_admin_ui would be more appropriate, I think, given that Navigation bar is not present only in the admin theme, but also in the main theme.

  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    Okay, I'll talk to Tim about this and come back with a plan of action.

Production build 0.71.5 2024