Contrib.social

Form classes should not inject the messenger

Open on Drupal.org →
Created on 14 October 2024, 6 months ago

Problem/Motivation

Some of our form classes are injecting the Messenger service. This is not needed since the FormBase class uses the MessengerTrait so the messenger is already available.

Proposed resolution

  1. Remove the injection of the Messenger service from ::__construct() and ::create().
  2. Replace $this->messenger property accesses with $this->messenger() method calls.

Remaining tasks

Affected forms:

  • ContactForm
  • EventInstanceDeleteForm
  • EventInstanceForm
  • EventInstanceRevisionDeleteForm
  • EventInstanceRevisionRevertForm
  • EventInstanceTypeForm
  • EventSeriesDeleteForm
  • EventSeriesForm
  • EventSeriesRevisionDeleteForm
  • EventSeriesRevisionRevertForm
  • EventSeriesTypeDeleteForm
  • EventSeriesTypeForm
  • ExcludedDatesDeleteForm
  • ExcludedDatesForm
  • IncludedDatesDeleteForm
  • IncludedDatesForm
  • RegistrantDeleteForm
  • RegistrantForm
  • RegistrantResendForm
  • RegistrantTypeForm

API changes

Since this requires a change to the class constructor this affects B/C compatibility with code that might subclass our forms. Because of this, this can only be done in the 3.x branch.

📌 Task
Status

Active

Version

3.0

Component

Recurring Events (Main module)

Created by

🇧🇬Bulgaria pfrenssen Sofia

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024