- Issue created by @benjifisher
- Merge request !8Use the array of validators in the correct format depending on the version of Drupal β (Merged) created by benjifisher
- πΊπΈUnited States benjifisher Boston area
The change record (CR) does not mention how to support multiple versions of Drupal. If we agree that the approach I took is good enough, then I will add something to the CR.
I tested manually with Drupal 11. It is already past my bedtime, so I am not going to test with an older version of Drupal. Maybe GitLab CI will do that for me.
Does this bug fix need regression testing?
- heddn Nicaragua
Just bump the minimum version of Drupal support to 10.2 and we'll drop pre 10.2 support.
- πΊπΈUnited States benjifisher Boston area
But that is so easy!
I have been looking at this module along with
migrate_plus
andmigrate_source_csv
. Both of those declare compatibility with Drupal core>= 9.1
, and I did not notice that this one declared^10.1 || ^11
.Back to NR.
- πΊπΈUnited States benjifisher Boston area
One of the phpstan tests reports,
150 Fetching deprecated class constant EXISTS_REPLACE of interface
Drupal\Core\File\FileSystemInterface:
in drupal:10.3.0 and is removed from drupal:12.0.0. Use
\Drupal\Core\File\FileExists::Replace instead.The change record FileSystemInterface replace behaviour constants deprecated and replaced with an enum β suggests some ways to support new and old versions, but I suggest not making any changes as part of this issue.
Would you like me to open a Postponed issue to change this when the minimum version goes to 10.3, or just wait for the automated updates for Drupal 12 compatibility?
-
heddn β
committed d2b1543d on 8.x-1.x authored by
benjifisher β
Issue #3480275 by benjifisher, heddn: File validation changed in Drupal...
-
heddn β
committed d2b1543d on 8.x-1.x authored by
benjifisher β
Automatically closed - issue fixed for 2 weeks with no activity.