Field subject can be disabled

I've created a MR.

PS: I'm (not so) sorry to use the "@", I think no one likes it except me. I think here it's the shortest and cleanest fix. Feel free to add the much more consensual "?? NULL" instead, that's just about the same AFAIK :)

I've created a MR.

PS: I'm (not so) sorry to use the "@", I think no one likes it except me. I think here it's the shortest and cleanest fix. Feel free to add the much more consensual "?? NULL" instead, that's just about the same AFAIK :)

I think we should not even set the variable is such case

`
// The field subject can be disabled.
if (isset($form_copy['subject'])) {
$form['subject'] = $form_copy['subject'];
}
`

Updated code with this below :

if (isset($form_copy['subject'])) {
$form['subject'] = $form_copy['subject'];
}

The use of the @ symbol in PHP is generally discouraged because it suppresses errors, which can make debugging difficult. Instead, we should use proper checks like isset() or empty() to safely handle variables.

MR contains many not-related changes. Yes, some parts are valid, but we should stick to a specific issue.

I agree @zaryab_drupal, like this is better.

There are failing tests which are not related with this MR (I see them also in main branch).
I mark the issue as RTBC.

claudiu.cristea → made their first commit to this issue’s fork.

Thank you

Automatically closed - issue fixed for 2 weeks with no activity.