Make pagination more consistent.

Created on 11 October 2024, 6 months ago

Problem/Motivation

So when a user has 2 browse(Project browser) tabs open and if a user changes the value of number of modules that the user wants to see from say 12 items per page to 24 items per page and then visit the second tab and refresh the tab, then ideally it should also have the change in the value of pagination reflected ie now no of items per page should be set to 24 for both the tabs.

Steps to reproduce

Open 2 browse windows and then set the value of items per page to any thing other than the default value and then navigate to the other browser tab and refresh.
You would notice different values in Items per page across the 2 tabs.

Proposed resolution

🐛 Bug report
Status

Active

Version

2.0

Component

User experience

Created by

🇮🇳India utkarsh_33

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @utkarsh_33
  • Merge request !599#3480064: Make pagination more consistent. → (Merged) created by utkarsh_33
  • Pipeline finished with Success
    6 months ago
    Total: 933s
    #306918
  • 🇮🇳India utkarsh_33

    Not sure whether this needs test or not.

  • 🇺🇸United States chrisfromredfin Portland, Maine

    I think it does because I think if we revert the change accidentally elsewhere we'd want to know.

  • 🇺🇸United States chrisfromredfin Portland, Maine
  • Pipeline finished with Success
    5 months ago
    Total: 498s
    #344342
  • Pipeline finished with Failed
    5 months ago
    Total: 335s
    #344486
  • Pipeline finished with Failed
    5 months ago
    Total: 332s
    #344500
  • 🇮🇳India narendraR Jaipur, India

    This issue requires a new endpoint in DrupalOrgClientMiddleware. But filter ID's are changed on DO, so I think an update in fixture is required before working on this issue further. Next steps once fixture is regenerated:

    • Add testPagingOptions test in ProjectBrowserUiTestJsonApi.php also, which currently exists in ProjectBrowserUiTest.php
    • Add new endpoint in DrupalOrgClientMiddleware.php and use in above test
    • Fix nightwatch test.
  • 🇪🇸Spain fjgarlin

    I'm doing the fixes for the regeneration script at 🐛 Improve fixture regeneration script Active

  • Pipeline finished with Failed
    4 months ago
    Total: 538s
    #360860
  • Pipeline finished with Failed
    4 months ago
    Total: 405s
    #360955
  • Pipeline finished with Failed
    4 months ago
    Total: 439s
    #361057
  • Pipeline finished with Failed
    4 months ago
    Total: 363s
    #361071
  • Pipeline finished with Failed
    4 months ago
    Total: 286s
    #361078
  • Pipeline finished with Failed
    4 months ago
    Total: 370s
    #361089
  • Pipeline finished with Failed
    4 months ago
    Total: 446s
    #361094
  • Issue was unassigned.
  • Status changed to Needs review 4 months ago
  • 🇮🇳India utkarsh_33

    This is ready for reviews now.The CI fails are unrelated.

  • 🇺🇸United States chrisfromredfin Portland, Maine

    I have one small nit (filename) and then this needs manual testing but then is probably ready to go.

  • 🇮🇳India utkarsh_33

    Ready for review and manual testing.

  • Pipeline finished with Failed
    4 months ago
    Total: 448s
    #365042
  • 🇮🇳India narendraR Jaipur, India

    Tested manually, and the change in page size in one tab is properly reflected in another tab. Moving it to RTBC.

  • Pipeline finished with Skipped
    4 months ago
    #365975
  • 🇺🇸United States chrisfromredfin Portland, Maine

    teamwork makes the dream work.

  • Pipeline finished with Success
    4 months ago
    Total: 395s
    #365971
  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Failed
    2 months ago
    Total: 1048s
    #411102
  • Pipeline finished with Canceled
    2 months ago
    Total: 438s
    #412798
  • Pipeline finished with Failed
    2 months ago
    Total: 956s
    #412799
  • Pipeline finished with Failed
    2 months ago
    Total: 1212s
    #412985
  • Pipeline finished with Success
    2 months ago
    Total: 1194s
    #413048
  • Pipeline finished with Failed
    2 months ago
    Total: 2227s
    #413073
  • Pipeline finished with Canceled
    2 months ago
    Total: 1016s
    #413343
  • Pipeline finished with Canceled
    2 months ago
    Total: 685s
    #413369
  • Pipeline finished with Canceled
    2 months ago
    Total: 115s
    #413384
  • Pipeline finished with Success
    2 months ago
    Total: 999s
    #413388
  • Pipeline finished with Failed
    2 months ago
    Total: 811s
    #413437
  • Pipeline finished with Canceled
    2 months ago
    Total: 173s
    #413459
  • Pipeline finished with Canceled
    2 months ago
    Total: 108s
    #413463
  • Pipeline finished with Canceled
    2 months ago
    Total: 134s
    #413464
  • Pipeline finished with Success
    2 months ago
    Total: 898s
    #413465
  • Pipeline finished with Failed
    2 months ago
    Total: 1142s
    #413570
  • Pipeline finished with Failed
    2 months ago
    Total: 891s
    #413698
  • Pipeline finished with Canceled
    2 months ago
    Total: 160s
    #413724
  • Pipeline finished with Success
    2 months ago
    Total: 1061s
    #413728
  • Pipeline finished with Skipped
    2 months ago
    #413770
Production build 0.71.5 2024