- Issue created by @Istari
- 🇵🇱Poland Graber
Are you sure that's on 1.0.x branch?
In any case, if there is some code that can be converted, pls go ahead, but if it's on 0.2.x - no point. - Merge request !39Issue-3479899-adjust-to-proper: Added proper dependency injection wherever... → (Merged) created by divyansh.gupta
- 🇮🇳India divyansh.gupta Jaipur
Added dependency injections where ever found direct drupal calls.
- 🇮🇳India divyansh.gupta Jaipur
I have made some more changes to it.
- 🇵🇱Poland Graber
Pls don't set to "needs review" if tests still fail.
- First commit to issue fork.
- 🇬🇧United Kingdom catch
Did some clean-up here, various things were causing the test failures:
- it's not necessary to inject the messenger service into forms, you can use $this->messenger() from MessengerTrait
- various constructors weren't calling the parent constructor (and create/createInstance methods similarly weren't passing the right arguments).
- remove unnecessary constructor documentation
- reverts the places using $this in static methods which isn't possible
Tests should be back to green now.
- 🇬🇧United Kingdom catch
This gets us down from 26 to 21 phpstan errors.
-
graber →
committed d5cdeb11 on 1.0.x authored by
divyansh.gupta →
Issue #3479899: Adjust to proper dependency injection
-
graber →
committed d5cdeb11 on 1.0.x authored by
divyansh.gupta →
Automatically closed - issue fixed for 2 weeks with no activity.