- Issue created by @marcus_johansson
- First commit to issue fork.
- 🇬🇧United Kingdom scott_euser
Mostly there as discussed in Slack. And for benefit of those here only, since we are still alpha, we are just wiping the logs to not migrate the log content from the single old entity to the two new entities. Update hook will do that wiping.
Random test failure unrelated, seems from mockoon maybe
-
scott_euser →
committed 9c653f38 on 1.0.x
Issue #3479566 by scott_euser, marcus_johansson: Make AI Logs Entity...
-
scott_euser →
committed 9c653f38 on 1.0.x
- 🇬🇧United Kingdom scott_euser
Thank you! Added a quick final fix for a fatal error linked to from breadcrumb from my original code, but otherwise nice defaults!
- 🇩🇪Germany vesnag
Hi both, my question isn't directly related to the original issue, so please let me know if I should create a new ticket for it.
I'm wondering whether the
"edit-form" = "/admin/config/ai/logging/collection/{ai_log}/edit"
is necessary for the logs, or if users should not have the ability to edit logs? - 🇬🇧United Kingdom scott_euser
Yeah for that reason we just have a seperate permission just for the view logs as that's probably all a non site builder needs.
The edit/add is really only useful to see youve configured custom fields right when you want to store extra info, so no real need for a special permission for that.
But if you're logged in as admin you see everything of course as you bypass access controls.
- 🇩🇪Germany vesnag
Should "Response" and "Extra data" be trimmed in "en/admin/config/ai/logging/collection"?
- 🇬🇧United Kingdom scott_euser
Yeah there are definitely some things that would help improve the UX
- The one you mentioned trimming
- From your screenshot, maybe some of those things current in JSON could be fields on the 'Generic' type like streamed and system prompt
- Having the tags one per line so they are more readable
- Probably more...
They could all be follow-ups and fine to be separate if you do want to contribute one or more bits yourself.
Thanks in any case for the feedback!
- 🇬🇧United Kingdom scott_euser
Actually hiding the edit link by default seems easy in the Fields section of the View since really only useful to see the add form here which is already hidden in the AI Log Types section:
- 🇩🇪Germany vesnag
I have created a new ticket https://www.drupal.org/project/ai/issues/3479837 📌 Improve UX for AI Logs collection view Active to address these improvements. I'll be working on that.
Automatically closed - issue fixed for 2 weeks with no activity.