- Issue created by @Kristen Pol
- First commit to issue fork.
Seems to work pretty well right now. Definitely could use some work on the CSS end, it can sort of break components when used in a slot.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Thanks. Can you add some screenshots where it shows as broken?
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
It would be good to do a side-by-side comparison with Storybook to see if it matches:
And ideally record the testing of all the props so we can see where the issues are to determine if the issues are on our end or on the XB end.
I added the themes prop and it works. Currently I've been using this branch to test a bunch of stuff, so I'll need to clean it before any MRs can be done. As for a recording, I don't think I can provide a useful one from my end here because it's working perfectly fine for me, it's the same as the storybook component.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Talked with Jacob about the vertical spacing/padding and how maybe that could be a more general "spacer" type component/option so added here:
π Suggestions for additional SDDS components for testing XB Active
Jacob, we can put that one as stable now.
Afterwards, we can see if anyone in the community would like to do some testing.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Not moving forward with the spacer idea at the moment given community feedback.
This issue is open for review/testing from others in the community.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Working as expected based on testing, so marking fixed.
Automatically closed - issue fixed for 2 weeks with no activity.