Integrate SDDS base theme button component with XB

Created on 7 October 2024, 4 months ago

Problem/Motivation

Test+tweak base theme button component to work with XB.

Steps to reproduce

Proposed resolution

Test+tweak base theme button component to work with XB.

Remaining tasks

See above.

User interface changes

Component will work with XB.

API changes

Data model changes

πŸ“Œ Task
Status

Active

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Kristen Pol
  • Notes on the current state of Button:
    - Doesn't open its link
    - Greys out when any props are changed
    - Icon props don't do anything

  • πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

    Thanks. Can you compare it against the subtheme button for the first two items? Also, check out some of the other components with icons as I think I tweaked some so they pull in the existing icons.

  • πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

    It would be good to do a side-by-side comparison with Storybook to see if it matches:

    https://uikit.civictheme.io/

    And ideally record the testing of all the props so we can see where the issues are to determine if the issues are on our end or on the XB end.

    Here's an example with all the icons noted:

    starshot_demo/components/01-atoms/button/button.component.yml

Production build 0.71.5 2024