Integrate SDDS base theme link component with XB

Created on 7 October 2024, 4 months ago

Problem/Motivation

Test+tweak base theme link component to work with XB.

Steps to reproduce

Proposed resolution

Test+tweak base theme link component to work with XB.

Remaining tasks

See above.

User interface changes

Component will work with XB.

API changes

Data model changes

πŸ“Œ Task
Status

Active

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Kristen Pol
  • πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

    It would be good to do a side-by-side comparison with Storybook to see if it matches:

    https://uikit.civictheme.io/

    And ideally record the testing of all the props so we can see where the issues are to determine if the issues are on our end or on the XB end.

  • Here's a video of me messing around with it. It looks pretty good. I think there's an XB glitch where the starting props won't always display right. For example it starts with the disabled state prop being ticked. This one is actually false in the yml, so it's showing wrong, but then if you mess around with other props it actually selects it as true and the link goes grey. I think something similar could be happening for the button component.

  • πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

    I do wonder if that defaulting stuff may be related to other default/examples issues we are seeing. Let's not report this until the other XB bug is fixed though as maybe fixing that will fix this. Let's not close this issue (or we can open a separate one in our queue) so we don't lose this as an example of the bug.

    I created this:

    πŸ“Œ Update SDDS components in base and subtheme so default and examples are the same Active

    Add icons to the list to make a enum/select list.

Production build 0.71.5 2024