incorrect docs for EntityContentBase 'translations' configuration option

Created on 7 October 2024, about 2 months ago

Problem/Motivation

 * - translations: (optional) Boolean, indicates if the entity is translatable,
 *   defaults to FALSE.

This doesn't seem right.

AFAIK, you set this to FALSE for the migration that handles the default language version. Then in a 2nd migration which does the translations, you set this to TRUE.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

🐛 Bug report
Status

Active

Version

11.0 🔥

Component

documentation

Created by

🇬🇧United Kingdom joachim

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @joachim
  • 🇬🇧United Kingdom joachim

    Input from @mikelutz on Slack:

    > On the technical side, it does 2 things. It adds the langcode as a destination id, and on the import side makes sure that you are creating or updating a translation of an existing entity, instead of trying to create a new entity or attempting to change the base language of an existing entity.

    > It’s real purpose is to add the langcode as an ID and to update a translation instead of trying to update the base entities langcode. As such, with the old style migrations, you would migrate the base translations first, without setting translations to true, and then migrate the translations in a separate migration that looks up the node ids of the original translations and wants to update/add a translation of that, so we would set translations:true for that one.

    > It is possible to migrate all base languages and translations in one shot with a source that has the right configuration using one migration with translations:true, but core didn’t do it that way.

    Some of the above needs to be picked out and used for fixing the docs.

    Core maintainers: please add credit for @mikelutz.

  • Merge request !9786Fixed documentation for translations property. → (Open) created by joachim
  • Pipeline finished with Failed
    about 2 months ago
    Total: 763s
    #304254
  • 🇺🇸United States mikelutz Michigan, USA
  • 🇺🇸United States smustgrave

    Re-ran test failures and as expected random.

    Reading the change and to me in reads just fine. Believe should be good.

  • 🇳🇿New Zealand quietone

    I don't think this should remove the point that 'translations' "indicates if the entity is translatable".

  • 🇮🇳India akulsaxena

    @quietone, I'll make the necessary changes suggested in the comments.

  • 🇮🇳India akulsaxena

    @quietone
    I made the suggested changes in the documentation
    Please take a look

  • Pipeline finished with Canceled
    8 days ago
    Total: 176s
    #349239
  • 🇮🇳India akulsaxena

    I also rebased the fork to the latest changes
    Please take a look

  • Pipeline finished with Failed
    8 days ago
    Total: 679s
    #349243
  • Pipeline finished with Failed
    8 days ago
    Total: 533s
    #349256
  • Pipeline finished with Success
    8 days ago
    Total: 7671s
    #349542
  • Pipeline finished with Success
    6 days ago
    Total: 583s
    #351858
  • Pipeline finished with Success
    6 days ago
    Total: 729s
    #352727
  • 🇮🇳India akulsaxena

    Rebased the fork to the latest changes

  • Pipeline finished with Success
    1 day ago
    Total: 1796s
    #356052
  • 🇮🇳India akulsaxena

    Pipeline run and passed with no errors or warnings

Production build 0.71.5 2024