Contrib.social

InputConfigurator::collectAll() should use an internal passed-in recursion tracker, not a static variable

Open on Drupal.org →
Created on 7 October 2024, about 2 months ago

Problem/Motivation

As it recurses down a stack of recipes, \Drupal\Core\Recipe\InputConfigurator::collectAll() uses an internal static variable to keep track of which recipes it has already looked at. A static is not a good idea, since it will persist across all instances of InputConfigurator that are instantiated in the PHP runtime, and that could have weird side effects.

We should replace with a function argument that gets passed in to recursive calls and is explicitly marked internal.

🐛 Bug report
Status

Active

Version

11.0 🔥

Component

recipe system

Created by

🇺🇸United States phenaproxima Massachusetts

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024