Add function return type for DomainTestBase::drupalUserIsLoggedIn

Created on 7 October 2024, 3 months ago

Problem/Motivation

PHPUnit tests for Drupal next major are failing due to a missing return type:

PHP Fatal error:  Declaration of Drupal\Tests\domain\Functional\DomainTestBase::drupalUserIsLoggedIn(Drupal\Core\Session\AccountInterface $account) must be compatible with Drupal\Tests\BrowserTestBase::drupalUserIsLoggedIn(Drupal\Core\Session\AccountInterface $account): bool in /builds/issue/domain-3479098/domain/tests/src/Functional/DomainTestBase.php on line 203

See for example https://git.drupalcode.org/issue/domain-3479098/-/jobs/2975840

Proposed resolution

Add function return type for DomainTestBase::drupalUserIsLoggedIn

📌 Task

Status

Active

Version

2.0

Component

Code

Created by

🇳🇱Netherlands idebr

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @idebr
@idebr opened merge request.
Comment 3 months ago →
🇳🇱Netherlands idebr
The merge request adds a function return type for DomainTestBase::drupalUserIsLoggedIn and fixes the PHPUnit tests for the next major Drupal version
Comment 3 months ago →
🇩🇪Germany webflo
Fixed with https://git.drupalcode.org/project/domain/-/merge_requests/116

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024